Metadata
- Source
- VP-92
- Type
- Bug
- Priority
- Blocker
- Status
- Closed
- Resolution
- Fixed
- Assignee
- Colin Clark
- Reporter
- Anastasia Cheetham
- Created
2012-08-09T10:56:08.860-0400 - Updated
2013-01-28T09:25:22.740-0500 - Versions
- N/A
- Fixed Versions
- N/A
- Component
- N/A
Description
There are some console.log() commands in VideoPlayer_framework.js and VideoPlayer_uiOptions.js that don't work in IE unless the console is open. If the console is not open, the video player doesn't instantiate. We should convert these to fluid.log() statements.
Environments
IE
Comments
-
Colin Clark commented
2012-08-09T11:28:08.297-0400 Logging statements should typically be removed prior to committing production code. We might prefer to pursue the strategy where these statements are simply removed from the code base unless they're integral to an ongoing debugging effort.
-
Michelle D'Souza commented
2012-08-15T13:19:21.164-0400 I agree with you that production code should not have logging statements in it. I think it might be worth leaving these in but commented out for now. My reasoning is that the code in question is going to be removed as soon as we move to using the new supports available in the framework. Until that time, if we do hit a breakage in the code, I like the idea of being able to debug it quickly. I suppose it speaks to the untested and non-production qualities of the code in question.
-
Michelle D'Souza commented
2012-08-15T13:19:44.910-0400 Merged into project repo demo branch at c2949219b0e63a802b5e38b1f9ccd9d95eb722a2