VP-37: Increasing volume with keyboard may destory the sound completely

Metadata

Source
VP-37
Type
Bug
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
N/A
Reporter
Cindy Li
Created
2012-08-13T15:56:35.390-0400
Updated
2013-01-28T09:25:21.459-0500
Versions
N/A
Fixed Versions
N/A
Component
N/A

Description

On the video player demo, play the video, keep pressing shift + up arrow to increase volume. At one point when the maximum sound level is exceeded, the sound disappears completely. Need to refresh page to get the sound back.

Environments

firefox 14.0.1, chrome

Comments

  • Antranig Basman commented 2012-08-15T12:48:56.458-0400

    There is already code in the VideoPlayer to make sure that the volume stays within the range 0.100 at line 457 of VideoPlayer.js - we should look into why this is not working rather than pollute the codebase with manual checks

    that.applier.guards.addListener({path: "volume", transactional: true}, fluid.linearRangeGuard(0, 100));

  • Michelle D'Souza commented 2012-08-29T13:55:25.689-0400

    Merged into project repo demo branch at cb56354d7d921c0604cc4f7d92f1e6bab838a8f5