VP-202: Reconsider using 'timeupdate' event for keeping model in sync with video

Metadata

Source
VP-202
Type
Bug
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
Cindy Li
Reporter
Anastasia Cheetham
Created
2011-11-29T08:49:01.176-0500
Updated
2013-01-28T09:25:25.017-0500
Versions
N/A
Fixed Versions
N/A
Component
N/A

Description

In VideoPlayer-media.js, in the bindMediaDOMEvents() function, the 'timeupdate' event is used to trigger a double-check of the currentTime against the duration. This seems a bit expensive to do on every 'timeupdate' event. We should consider if there is another way to accomplish the same goal.

Comments

  • Cindy Li commented 2012-02-16T16:18:11.760-0500

    The fix has been merged into master @ d4cc8caa2de4e18add0ccbf6d03fe367479cf2c2

  • Cindy Li commented 2012-02-16T16:18:23.983-0500

    Issue resolved.