Metadata
- Source
- VP-200
- Type
- Bug
- Priority
- Major
- Status
- Closed
- Resolution
- Fixed
- Assignee
- Michelle D'Souza
- Reporter
- Anastasia Cheetham
- Created
2011-11-28T16:59:51.889-0500 - Updated
2013-01-28T09:25:24.976-0500 - Versions
- N/A
- Fixed Versions
- N/A
- Component
- N/A
Description
There are a few small things we can do to clean the code up, including:
- remove commented code
- remove empty listeners block on line 122 of the controllers file
- define the controller types as constants (line 170 of VideoPlayer.js and any other place that uses those strings)
Comments
-
Anastasia Cheetham commented
2011-11-29T14:45:22.603-0500 We should also include a JSLint once-over: add the Infusion JSLint options to the head of each of the files and run them through JSLint once just to double-check that they're in good shape. Then we can simply keep them up-to-date as we go.
The header we're currently using is:
// JSLint options
/*jslint white: true, funcinvoke: true, undef: true, newcap: true, nomen: true, regexp: true, bitwise: true, browser: true, forin: true, maxerr: 100, indent: 4 */and we're running it through our version of JSLint at
-
Anastasia Cheetham commented
2011-11-29T15:28:41.917-0500 I've issued a pull request for this:
https://github.com/fluid-project/videoPlayer/pull/4 -
Michelle D'Souza commented
2011-11-30T11:18:14.606-0500 Merged into project repo at 708d2a5fc80277becebeccca0d33fce02aa63379