VP-126: Make inputs larger doesn't change the buttons size

Metadata

Source
VP-126
Type
Bug
Priority
Blocker
Status
Closed
Resolution
Fixed
Assignee
Anastasia Cheetham
Reporter
Michelle D'Souza
Created
2012-03-08T16:45:10.459-0500
Updated
2013-02-26T15:46:37.390-0500
Versions
  1. 0.1
Fixed Versions
  1. 0.1
Component
  1. controls
  2. UIO integration

Description

Make inputs larger doesn't change the buttons size. Check in with a designer for what should happen.

Comments

  • Anastasia Cheetham commented 2012-10-24T14:30:23.361-0400

    The buttons do enlarge with increased font size, according to what seems to be shown in the visual designs:
    http://wiki.fluidproject.org/display/fluid/Floe+video+player+design+(February+2012)

    We might want to give this a bit of thought. It does seem that since they're buttons, they should enlarge with buttons, not with font size.

  • Anastasia Cheetham commented 2012-10-25T11:14:39.626-0400

    This really should be addressed in UIO.

  • Jonathan Hung commented 2012-12-07T14:13:55.965-0500

    This problem occurs because the buttons are just background images with no content. Thus changing the text size does not change the size of the buttons. If we used a graphical font instead of a background image, then we may be able to scale the buttons with the text size option.

    Something like IcoMoon may help.

  • Anastasia Cheetham commented 2012-12-12T16:35:48.278-0500

    The problem is NOT because the buttons are just background images. The current scaling technique (setting the font size to 125%) would work if the size of the buttons was specified in ems. In the case of the video control buttons, they're NOT specified in ems, they're specified as a percentage of their container size.

    So the solution may be to re-jig the base styles so that the button sizes are specified using ems instead of %.

  • Justin Obara commented 2012-12-19T09:20:30.528-0500

    Merged pull request ( https://github.com/fluid-project/videoPlayer/pull/101 ) into the project repo at 2afc880e5bbf25b8881da221a5d27f2086f25513

  • Jonathan Hung commented 2013-01-28T10:42:18.335-0500

    Reopening to assign proper fix version.