VP-125: Audio/Video UIO panel is empty

Description

At some point we lost the audio video panel. I would guess it happened when we upgraded Infusion.

Attachments

Comments

• Anastasia Cheetham commented 2012-09-18T15:36:35.915-0400

  The video panel is present and working in the Mammals demo. The simple demo simply doesn't use the media-panel version of UIO. Not sure it ever did, but I'll set it up so that it does.

• Colin Clark commented 2012-09-18T18:00:12.017-0400

  Just before I review and commit the pull request associated with this issue (https://github.com/fluid-project/videoPlayer/pull/59/files), I want to make sure I understand the issue correctly.

  In the screenshot, I see the "Audio + Video" tab present, but when it's activated, there's no panel associated with it. In the pull request, the fix appears to be to add the panel by instantiating the "withMediaPanel" flavour of UIO.

  But how did the Audio + Video tab get there? My only concern is to be sure that ordinary users of UIO don't, by default, see this additional, broken, tab.

  Can you take a look and elaborate a bit for me, Anastasia?

  Thanks!

• Anastasia Cheetham commented 2012-09-20T11:47:55.480-0400

  Thanks for catching this, Colin. The media panel is added as a customization of the local UI Options template files (i.e. local to the Video Player), but the changes that were made had not been documented anywhere. I've updated the Infusion README in the lib/infusion folder to include the diffs.

  Because the changes are local to the Video Player integration, they have no effect on anyone else using UI Options. However, it does mean we need to be diligent if the base HTML files are updated.

• Colin Clark commented 2012-09-20T12:41:36.806-0400

  Reviewed, tested, and commited to the project demo branch at 0193a920a34c1bf39ac123184348bf29a6ae5873.