SJRK-99: Storytelling tool unable to save in certain circumstances

Description

As reported by @@Michelle D'Souza: "Another issue that we hit - and I saw it on my phone too, was an inability to save. I was able to save a simple story, but when I tried to enter one that a student had sent us, it failed. One thing she did was put some emojis in the text as well as the title and the keywords. Dana can WhatsApp you the story."

The emoji are likely a factor, worth exploring

Comments

• Gregor Moss commented 2018-05-29T12:57:54.469-0400

  I tested adding stories from my phone (Google Pixel XL, Android 8.1.0):

  • one with emoji in a text block (in the 'text' field)
  • one with emoji in the title as well as a text block (again in the 'text' field)
  • one with emoji in the keywords as well as title and text block

  All seemed to save without issue while connected to the OCADU wireless network. Is it possible that certain emoji are causing it to trip up?

• Gregor Moss commented 2018-05-30T16:57:18.121-0400

  In testing on a Nexus 7 (2012) running Android 5.1.1 and Chrome 53 (mentioned in my tests for SJRK-98), I noticed I was unable to save when an image block was added to the story. I connected the device to my machine and did remote debugging in order to inspect the browser console, and this error appeared when an image block was added:

  Fluid.js:203 Uncaught Error: Assertion failure - check console for more details: Failed to resolve reference {editable}.updateImagePreview - could not match context with name editable from component { typeName: "sjrk.storyTelling.block.singleFileUploader" gradeNames: ["sjrk.storyTelling.block.singleFileUploader"] id: a8x2muug-4040} at path storyEdit-a8x2muug-83,storyEditor,blockManager,managedViewComponents,cameraCaptureUploader component: [object Object]

  And when trying to save, this is the response from the server:

  {"isError":true,"message":"Unexpected field","code":"LIMIT_UNEXPECTED_FILE","field":"uploadedFile","storageErrors":[]}

  And after switching the language to Spanish, the response becomes

  {"isError":true,"message":"Cannot read property 'filename' of undefined","stack":"TypeError: Cannot read property 'filename' of undefined\n at Arguments.<anonymous> (/usr/src/app/src/js/requestHandlers.js:147:40)\n at ...}

• Gregor Moss commented 2018-05-30T17:42:42.448-0400

  The issue seems to have been a leftover IoC reference from a time before the current factoring. it refers to {editable}, which no longer exists. I've updated it to {imageBlockEditor} as it should be, and the client-side error stopped happening.

  I have pushed this fix to SJRK-91 branch. Once the server build has been updated, we can retry.

  cc @@Alan Harnum @@Michelle D'Souza @@Dana

• Gregor Moss commented 2018-06-05T16:33:44.905-0400

  The LIMIT_UNEXPECTED_FILE error mentioned above was due to the fact that the upload element names used in the withCamera imageBlockEditor template (storyBlockImage-withCameraCapture.handlebars) were not handled by the Multer middleware.

  The solution to this is to change the "name" fields for both upload elements in the template to "file".

  Edit: solution implemented, seems to work when tested locally