Metadata
- Source
- SJRK-459
- Type
- Bug
- Priority
- Major
- Status
- Closed
- Resolution
- Fixed
- Assignee
- N/A
- Reporter
- Justin Obara
- Created
2021-03-08T12:24:21.270-0500 - Updated
2021-03-15T11:19:11.846-0400 - Versions
- N/A
- Fixed Versions
-
- 0.5
- Component
-
- Storytelling Tool UI
Description
The blockUi-timeBased-Tests are timing out/failing in CI builds. (See: fluid-work matrix discussion) These tests use a video file for the tests and have had issues in the past related to video format (See: SJRK-122).
These test failures actually appeared without any new code being committed to the repo. However, the Ubuntu test runner was updated to use the latest version of FF, v86. The tests have a context awareness check for mp4 support. However in this version of FF it the canPlayType
function returns "maybe" instead of "". Which causes the check to pass and the mp4 file to be used. Running FF in Ubuntu requires the webM version to be used.
Interestingly the tests pass after a page reload. Presumably that is enough to tell the browser that the video, in fact, will not play and provide the expected response to the canPlayType function. This is not suitable for the tests though.
Comments
-
Justin Obara commented
2021-03-08T12:28:39.659-0500 I tried the following possible solutions, the last one is the one that seemed to work.
- change the support check to test if canPlayType returns "probably".
- Caused the tests to fail in Safari.
- provide multiple sources in the video element.
- The video was still trying to use the mp4 format despite having access to both the mp4 and webm versions. It also didn't appear to matter what order the sources were added in.
- change the context check to see if webm is supported and fallback to mp4 instead of the other way around.
- this appears to work.
- change the support check to test if canPlayType returns "probably".
-
Justin Obara commented
2021-03-08T12:32:27.997-0500 Being worked on along with SJRK-455
-
Justin Obara commented
2021-03-15T11:19:11.845-0400 Address in the PR for SJRK-455
Merged PR ( https://github.com/fluid-project/sjrk-story-telling/pull/114 ) at ffa60fe828fa816fadca949aaccbec6f682b7ebe