SJRK-452: Adding a file to a media block before setting other fields results in error

Description

Adding a file to a media block before setting other fields results in an error being thrown. This is likely because simply adding a block to the story won't result in the story being saved to the server, indeed not until one of the text fields is updated, therefore there isn't a story ID to associate the file with while saving it to the server. Without fixing this bug, the only way around it is to clear the browser's local storage, which an author may not know to do nor know how to do.

A solution would be to have the story save to server when the first block is added, or on the first metadata change. This may require adjusting the configuration of the model listener that's currently (at time of filing) set up for creating stories on the first model change.

To reproduce:
1. Go to the Story Edit page
2. Add an image block
3. Click "Upload Image"
4. Pick a file to upload

Expected
The image uploads successfully and the preview is shown in the block editor

Actual
The uploader returns an error: Uploading failed: Error retrieving story with ID null

Attachments

Comments

• Justin Obara commented 2021-02-24T11:21:51.722-0500

  This is being worked on in the branch for SJRK-404. The solution is to create the initial story on block creation or story model change (to account for metadata additions). In addition the storyId was moved into the model for the editor block and uploader component. This is because we need to have dynamic access to the storyId which may be set after the block itself has been created. However, there is still the potential case where the story hasn't finished creation on the server before the user attempts to upload an image. In that case they may still see the error initially, but should be able to re-upload the image after the story has been created.

• Justin Obara commented 2021-03-15T12:18:51.870-0400

  Addressed alongside SJRK-404.

  The pull request that implements this feature has been merged into the main branch at this commit.