Metadata
- Source
- SJRK-417
- Type
- Improvement
- Priority
- Major
- Status
- Closed
- Resolution
- Fixed
- Assignee
- N/A
- Reporter
- Gregor Moss
- Created
2020-10-27T02:55:33.503-0400 - Updated
2021-01-21T09:38:03.639-0500 - Versions
- N/A
- Fixed Versions
-
- 0.5
- Component
-
- Storytelling Tool Server
- Storytelling Tool UI
Description
What needs doing:
Remove all references to ESLint global variables which are already defined in configuration files. Namely "fluid" and "sjrk". "jqUnit" and a small handful of other values are defined as well, but not commonly enough to add to the
overall config file for the project.
Why it needs doing:
As highlighted by this review feedback by @@Justin Obara on the SJRK-289 pull request, the ESLint global variable declarations which are present in many files are repetitive and can instead be defined just once in the .eslintrc.json file.
Previous attempts at this ran afoul of the linter, but the configuration and tools now seem to agree (at time of filing)
Comments
-
Justin Obara commented
2020-10-27T07:29:27.374-0400 This would seem to be a good time to update to the latest version of fluid-grunt-lint-all.
-
Justin Obara commented
2020-12-09T07:27:39.843-0500 Being worked on with changes to SJRK-405
-
Justin Obara commented
2021-01-21T09:38:03.635-0500 Merged PR ( https://github.com/fluid-project/sjrk-story-telling/pull/105 ) into project repo at 3845afd05c22ba96283c4558581b90e69ea47319