Metadata
- Source
- SJRK-362
- Type
- Bug
- Priority
- Major
- Status
- Closed
- Resolution
- Fixed
- Assignee
- Giovanni Tirloni
- Reporter
- Justin Obara
- Created
2020-06-15T08:39:39.713-0400 - Updated
2020-06-15T11:14:51.935-0400 - Versions
- N/A
- Fixed Versions
- N/A
- Component
- N/A
Description
Currently the stories.floeproject.org__staging CI task is running in forks and attempts to deploy to staging. This fails because the required secrets are not available in the fork.
Example failing build: https://github.com/jobara/sjrk-story-telling/runs/772418843?check_suite_focus=true
I don't know what the purpose of staging is exactly, as it's only run on pushes to master. I'd expect master to actually deploy to production, so not sure if there are other workflow steps. At any rate, it doesn't seem appropriate for forks to be attempting to deploy to staging, and the failing builds are confusing to those working on development. I'd suggest adding a conditional check to only run this task when triggered in the project's repository.
Comments
-
Justin Obara commented
2020-06-15T08:40:38.610-0400 @@Gregor Moss I assigned to @@Giovanni Tirloni because it looked like he originally worked on the CI tasks, but pinging you in the comments as well.