SJRK-272: Custom theme script loading may cause race condition

Metadata

Source
SJRK-272
Type
Improvement
Priority
Major
Status
Open
Resolution
N/A
Assignee
N/A
Reporter
Gregor Moss
Created
2019-09-03T16:52:25.379-0400
Updated
2019-09-03T16:52:25.379-0400
Versions
N/A
Fixed Versions
N/A
Component
  1. Storytelling Tool Server
  2. Storytelling Tool UI

Description

The current method of loading custom theme CSS files (via sjrk.storyTelling.loadCustomThemeFiles) can potentially lead to a race condition. The files are loaded via a call to [$.getScript|https://api.jquery.com/jQuery.getScript/], which will call its "success" callback after the script is loaded but not necessarily executed. The time between this loading and execution could therefore cause problems.

Look into how probable and/or possible this race condition is, and address it accordingly.

For further context on this issue, please refer to the discussion in the pull request review for SJRK-268: https://github.com/fluid-project/sjrk-story-telling/pull/39