SJRK-229: The background images for image and video blocks show at publishing empty blocks of these

Metadata

Source
SJRK-229
Type
Task
Priority
Critical
Status
Closed
Resolution
Fixed
Assignee
Gregor Moss
Reporter
Cindy Li
Created
2019-02-19T15:03:04.542-0500
Updated
2019-05-14T11:44:51.455-0400
Versions
N/A
Fixed Versions
N/A
Component
N/A

Description

To reproduce:

1. Open SJRK staging site;
2. Click add block buttons to add 4 empty blocks. Each of them is for text, image, audio, video;
3. Click "Continue" button. On the next page, click "preview my story" button;
4. The background images for image and video blocks show. The background image for the audio block doesn't show.

The expected behavior is none of these background images should show when adding empty blocks.

Attachments

Comments

  • Gregor Moss commented 2019-04-01T13:30:14.243-0400

    We want to disable the saving of empty blocks. If at some point we revisit this and decide that we want to enable that, we can.

  • Gregor Moss commented 2019-04-01T13:31:58.138-0400

    Some stories saved in the Storytelling Project efforts in the last few months have empty blocks exhibiting this behaviour. We won't be addressing those for the time being.

  • Cindy Li commented 2019-05-09T09:59:16.179-0400

    The pull request has been merged into the project repo at this commit.