Metadata
- Source
- SJRK-134
- Type
- Task
- Priority
- Major
- Status
- Closed
- Resolution
- Won't Do
- Assignee
- Alan Harnum
- Reporter
- Gregor Moss
- Created
2018-06-01T15:50:50.853-0400 - Updated
2018-07-12T11:04:37.874-0400 - Versions
- N/A
- Fixed Versions
- N/A
- Component
-
- Storytelling Tool Server
Description
tests/utils/storyFabricator.js is used to create random stories for development and testing purposes; it currently uses the unit testing framework to get access to some convenience functions, especially kettle.test.request.formData
We should move away from this and create a real factory-style method, rather than misusing the unit test framework.
Comments
-
Alan Harnum commented
2018-07-12T11:04:37.857-0400 Kettle itself actually does this in some places via an alternate function: https://github.com/fluid-project/kettle/blob/9ff8c535d095249b03ea299dde42c503ebe1bd99/kettle.js#L44-L48
I'm closing this one because it reflects current "best practice" in Kettle itself for getting access to the useful request functions outside of a testing context.