Metadata
- Source
- SJRK-120
- Type
- Task
- Priority
- Blocker
- Status
- Closed
- Resolution
- Done
- Assignee
- N/A
- Reporter
- Gregor Moss
- Created
2018-05-31T19:11:42.252-0400 - Updated
2018-08-24T13:15:16.042-0400 - Versions
- N/A
- Fixed Versions
- N/A
- Component
-
- Storytelling Tool UI
Description
There are some tests which should be added for sjrk.storyTelling.page:
uiLanguage changing and associated eventscheck its value when it's expected to have changed
onContextChangeRequested eventloading from and storing to cookieStorestorySpeaker listenerstorySpeaker creation timingtest the functions directly
Comments
-
Gregor Moss commented
2018-06-11T02:01:10.754-0400 Testing to ensure the timing of the page's compound event onAllUiComponentsReady based on menu's onControlsBound event was leading to errors. It seemed the test framework wasn't unbinding the first listener after it was called initally, and so when the language was changed it was reasserting that the onControlsBound event had fired, seemingly even after the components had been destroyed. I have commented out the test sequence item in question:
"event": "{pageTest page menu}.events.onControlsBound", "listener": "jqUnit.assert", "args": "menu onControlsBound event fired."
-
Gregor Moss commented
2018-06-26T18:11:12.515-0400 After adding tests for the cookieStore, including clearing the cookie after all tests, the tests for sjrk.storyTelling.page.storyEdit no longer completed because the cookie was missing. The exact cause of this is unclear at the moment, and I have worked around it by re-setting the language to English after all of the tests for sjrk.storyTelling.page have run. This is not ideal, and the cause should be determined and addressed.
-
Gregor Moss commented
2018-06-26T18:13:08.470-0400 I also experienced some difficulty in testing whether the cookieStore had loaded the expected values upon the page creation. It seems to be related to all of the other events which occur around the same time being tested against already. I was otherwise unable to figure out how to re-initialize the test page grade in order to restart this sequence, including firing its createOnEvent.
-
Gregor Moss commented
2018-08-24T13:15:15.968-0400 Test coverage was reviewed, two new tests were added and coverage is satisfactory to me at this point.