KETTLE-18: Bump expression dependency

Metadata

Source
KETTLE-18
Type
Bug
Priority
Minor
Status
Closed
Resolution
Fixed
Assignee
Javier Hernández
Reporter
Javier Hernández
Created
2013-09-09T06:56:25.759-0400
Updated
2015-08-26T20:38:25.893-0400
Versions
N/A
Fixed Versions
N/A
Component
N/A

Description

During the packagement of the kettle module for Fedora 19 I had to bump the express' version dependency [1] to match an available nodejs-express' package version from the Fedora repositories.

I ran Kettle's tests and they ended fine, the GPII still works (logged in and out successfully as some NP sets), so IMVHO this change seems to be secure.

[1]: https://build.opensuse.org/package/view_file/home:javihernandez:GPII:Factory/nodejs-kettle/bump-express-dep.patch?expand=1

Comments

  • Antranig Basman commented 2014-12-17T11:16:01.248-0500

    This appears to be a downgrade of express to version 3.3.5 which seems undesirable. But perhaps the diff has been expressed backwards. Also, this dependency should be resolved via npm rather than Fedora repositories so I'm not sure what the force of requirement is.

  • Antranig Basman commented 2015-08-26T20:38:25.890-0400

    Express was upgraded beyond this version in "old Kettle" long ago - also, "new Kettle" will bring us up to express trunk