FLUID-945: Inline Edit assumes there will always be a container element wrapping the display text. For simple scenarios, this is an unnecessary burden for the developer.

Metadata

Source
FLUID-945
Type
Bug
Priority
Major
Status
Closed
Resolution
Won't Fix
Assignee
N/A
Reporter
Anastasia Cheetham
Created
2008-07-18T17:35:33.000-0400
Updated
2011-01-20T15:09:43.244-0500
Versions
  1. 0.1
  2. 0.3
  3. 0.4beta1
  4. 0.4
  5. 0.5
Fixed Versions
N/A
Component
  1. Inline Edit

Description

At the moment, InlineEdit requires the display text to be contained in an element that is inside the component container. This is required, because the text needs to be hidden when switching into edit mode.

However, for some simple cases, this might be a burden on the developer, as it would be unnatural in the basic markup. For example, making the cells in a table editable: usually, the text in a cell is just in the <td> element, NOT inside an element inside the <td> element:
...
<td>Bootsy Collins</td>
...
In this example, the <td> element cannot be used as the container of an Inline Edit.

We should consider detecting this kind of case, and if necessary wrapping the text in a span ourselves.

Comments

  • Eli Cochran commented 2008-08-04T20:19:30.000-0400

    this seems to be related to, or actually superseding, FLUID-844

  • Antranig Basman commented 2008-11-13T21:45:51.000-0500

    See comments on FLUID-1541. I don't believe this issue should be resolved.