FLUID-928: Reorderer should provide callbacks for a variety of interesting moments

Metadata

Source
FLUID-928
Type
Sub-task
Priority
Blocker
Status
Closed
Resolution
Fixed
Assignee
N/A
Reporter
Colin Clark
Created
2008-07-16T21:47:08.000-0400
Updated
2011-02-22T16:27:51.951-0500
Versions
  1. 0.1
  2. 0.3
  3. 0.4beta1
  4. 0.4
Fixed Versions
  1. 0.5
Component
  1. Reorderer

Description

At the moment, the Reorderer provides a single callback: the orderChangedCallback. It is fired whenever the user has finished dropping an item.

However, there are a variety of interesting moments that should have callbacks:

  • afterGrab(grabbedElement)
  • afterMove(droppedElement)
  • onSelect(selectedElement)

Other delegate-style predicate functions would be helpful to allow users to override the Reorderer's default behaviour?

  • shouldSelect()
  • shouldMove()

It would also be helpful if the orderChangedCallback was given a list of the new order of elements, saving users the effort of walking the DOM for simple cases.

dev-iteration43

Comments

  • Antranig Basman commented 2008-09-12T17:01:19.000-0400

    As of revision 5530 event architecture is now generalised (see Fluid.js "mergeListeners" and "instantiateFirers" ) and it will be easy to freely add new "moments".

  • Antranig Basman commented 2008-09-17T23:58:52.000-0400

    Fixed at revision 5572. As of this revision the current set of supported events reads as follows:
    onShowKeyboardDropWarning: null,
    onSelect: null,
    onBeginMove: "preventable",
    onMove: null,
    afterMove: null,
    onHover: null

    This can be duly expanded but should be sufficient to be going on with. afterMove reports as well as the moving item, its target position and the complete list of movables.

  • Michelle D'Souza commented 2011-02-22T16:27:51.949-0500

    Closing issues that were resolved for 1.0 and earlier releases.