FLUID-677: Keyboard movement incorrect when items are selectable and drop targets but not movable.

Metadata

Source
FLUID-677
Type
Bug
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
Justin Obara
Reporter
Michelle D'Souza
Created
2008-05-29T19:44:59.000-0400
Updated
2008-09-08T13:35:25.000-0400
Versions
  1. 0.5beta1
Fixed Versions
  1. 0.5
Component
  1. Reorderer

Description

This happens when using the Reorderer API that takes a map of finder functions. Moving an item with the keyboard past a selectable item that is a drop target, causes the item that is moving to be placed after the next movable item not after the next drop target.

This can be seen in the 'list' manual test:
http://build.fluidproject.org/sakai-imagegallery-tool/tests/fluid-tests/manual/list/list.html

If you tab to the second list and move item 1 down, it will be placed after item 3 instead of after item 2.

There is an automated test in ReorderListTests that has been commented out due to this bug.

Comments

  • Antranig Basman commented 2008-09-07T18:37:47.000-0400

    Corrected at revision 5477

  • Michelle D'Souza commented 2008-09-08T10:48:33.000-0400

    This is still a problem. To see the issue, tab to the second list in the manual test and try to move item 1 below item 3.

  • Antranig Basman commented 2008-09-08T12:45:54.000-0400

    It seems that this was really two issues, and two different ones rather than a specific issue with non-movable items. The particular sample in question has a "fault" with its CSS styles in that the item collapses when it is in the "keyboard moving" mode. Secondly, even correcting the timing of geometry updates, revealed a further issue that the geometry manager did not quite behave correctly in the case of elements which abutted completely - a "half-open correction" needed to be added to allow both wrapping and downward motion to work correctly at the same time...

    Revision 5483