Metadata
- Source
- FLUID-6614
- Type
- Bug
- Priority
- Major
- Status
- Open
- Resolution
- N/A
- Assignee
- Antranig Basman
- Reporter
- Cindy Li
- Created
2021-04-20T13:46:47.944-0400 - Updated
2021-04-22T10:11:15.388-0400 - Versions
- N/A
- Fixed Versions
- N/A
- Component
-
- Framework
Description
Covid-data-monitor repo uses `fastXmlPull.js` from amb26/new-renderer-demo#FLUID-5047. This script appears stripping the opening comment sign when a template is loaded. This causes the issue that the table of content is shown with a string "Table of contents template -->" above "Table of Contents" header. See attached toc1.png.
Inspecting the DOM element shows the opening comment sign from the template of `tableOfContents.html` was removed. See attached toc2.png.
The demonstration of the issue can be produced at the deploy preview of this WeCount website PR.
This issue will not occur by using either one of workarounds below:
1. replace this version of `fastXmlPull.js` with the one from amb26/infusion#FLUID-6580;
2. remove the line of the comment from the table of contents template.
Attachments
Comments
-
Antranig Basman commented
2021-04-22T10:11:15.388-0400 I believe since the impl was simplified a few months ago to avoid the massive model relay CPU usage caused by the cities list, none of "new-renderer-demo" is actually being validly used in this project any more so I'll draw up a pull which simplifies the impl by removing them - I think every facility we are now using is part of the plain function of the FLUID-6580 "new renderer framework" which just consists of straightforward improvements to core Infusion