Metadata
- Source
- FLUID-6539
- Type
- Improvement
- Priority
- Major
- Status
- Closed
- Resolution
- Fixed
- Assignee
- Ned Zimmerman
- Reporter
- Justin Obara
- Created
2020-08-04T10:39:34.755-0400 - Updated
2020-10-27T16:46:21.393-0400 - Versions
- N/A
- Fixed Versions
- N/A
- Component
-
- Prefs Framework
- UI Options
Description
Currently the switch component markup has been implemented using a combination of <div> and <span> elements. It would be more semantic to use a <button> element instead. This would provide native support for things like disabling, and input handling.
See: https://www.smashingmagazine.com/2017/09/building-inclusive-toggle-buttons/
Switches are used for boolean adjusters in the prefs framework adjusters. (e.g. table of contents).
Comments
-
Justin Obara commented
2020-08-04T11:05:19.737-0400 Toggle button implementation from Pinecone: https://pinecone.netlify.app/components/detail/button--toggle-button.html
-
Justin Obara commented
2020-10-27T09:12:58.345-0400 Merged PR ( https://github.com/fluid-project/infusion/pull/1016 ) into the project repo at daeff32bd67a593b4f5819b314752d970c1e6cc0