Metadata
- Source
- FLUID-6316
- Type
- Improvement
- Priority
- Major
- Status
- Closed
- Resolution
- Fixed
- Assignee
- Tony Atkins [RtF]
- Reporter
- Tony Atkins [RtF]
- Created
2018-08-09T10:06:21.488-0400 - Updated
2024-07-22T10:35:02.633-0400 - Versions
- N/A
- Fixed Versions
- N/A
- Component
- N/A
Description
eslint-config-fluid makes use of fluid-grunt-eslint, but only lists it as a dev dependency. Depending in their direct and inherited dependencies, packages that use eslint-config-fluid which do not themselves depend on fluid-eslint may see errors like:
> grunt lint
Infusion at path /Users/duhrer/Source/rtf/gpii-testem/node_modules/infusion is at top level
12:54:01.350: Registering module gpii-testem from path /Users/duhrer/Source/rtf/gpii-testem/
12:54:01.351: Registering module infusion from path /Users/duhrer/Source/rtf/gpii-testem/node_modules/infusion/
12:54:01.351: Registering module infusion from path /Users/duhrer/Source/rtf/gpii-testem/node_modules/infusion
Loading "json-eslint.js" tasks...ERROR
>> Error: Cannot find module 'fluid-eslint'
12:54:01.355: Registering module gpii-grunt-lint-all from path /Users/duhrer/Source/rtf/gpii-testem/node_modules/gpii-grunt-lint-all
Warning: Task "json-eslint" not found. Use --force to continue.
The missing dependency is listed as a full dependency in fluid-grunt-eslint. I am creating a pull to move fluid-grunt-eslint to the main dependencies.