FLUID-6271: Buildkite Agent v3.0 breaks Vagrant builds

Metadata

Source
FLUID-6271
Type
Task
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
Giovanni Tirloni
Reporter
Giovanni Tirloni
Created
2018-04-16T20:02:14.135-0400
Updated
2024-07-22T10:35:21.881-0400
Versions
N/A
Fixed Versions
N/A
Component
  1. Infrastructure

Description

Previously, buildkite-agent v2.0 cleaned the git repository on every step using "git clean -fdq".

Version 3.0 switches to "git clean -fdqx", which removes all files even the ones in .gitignore. That was due to popular demand.

Unfortunately, that breaks our Vagrant steps because the ".vagrant" directory is wiped out.

Comments

  • Giovanni Tirloni commented 2018-04-16T20:36:32.543-0400

    The git clean flags are a per-agent configuration so I had to change /etc/buildkite-agent/buildkite-agent.cfg and add git-clean-flags to it:

    token="xxx"
tags="type=physical,hypervisor=virtualbox,docker=true,vagrant=true"
git-clean-flags="-fqd"

    The first build with v3.0 that ran correctly but still failed (unrelated to CI, it seems): https://buildkite.com/fluid-project/fluid-infusion/builds/195 – Waiting on @@Joseph Scheuhammer's feedback before closing this as fixed.

  • Joseph Scheuhammer commented 2018-04-17T15:21:30.832-0400

    @@Giovanni Tirloni I can confirm the console output I get when I run this pull request locally on my vagrant VM matches, in all relevant respects, the console output from buildkite (https://buildkite.com/fluid-project/fluid-infusion/builds/195).  The failure(s) observed are due to a bug in my testing code, not in what buildkite is doing.