FLUID-6250: fluid-publish should revert package-lock.json on conclusion

Metadata

Source
FLUID-6250
Type
Bug
Priority
Major
Status
Closed
Resolution
Migrated
Assignee
Justin Obara
Reporter
Antranig Basman
Created
2018-02-22T09:09:51.776-0500
Updated
2024-07-25T11:52:46.691-0400
Versions
N/A
Fixed Versions
N/A
Component
  1. fluid-publish

Description

npm version 5, the current LTS version, maintains a package-lock.json file in addition to package.json . The last step of the fluid-publish dev workflow should revert this file to its content from git in addition to the package.json file

Comments

  • Atisaya Jain commented 2018-03-12T02:31:55.800-0400

    Is this issue still open? I would like to work on this.

  • Justin Obara commented 2018-03-12T09:38:39.150-0400

    @@Atisaya Jain I believe this is still open. Please feel free to submit a PR to address it.

  • Atisaya Jain commented 2018-03-12T17:12:58.655-0400

    This might be silly, but I think I am a bit lost here. What does it mean to revert back to content from git? Does it mean that after publishing, fluid-publish should be removed from the package-lock.json and package.json files of the module it has been used to publish? Or does it mean something else?

    I would be grateful if you could help me how to approach this issue.

  • Tony Atkins [RtF] commented 2018-03-13T05:53:37.366-0400

    Hi, @@Atisaya Jain. For "dev" releases, this package generates a version number (based in part on the date) that is saved to the package.json file. The updated package.json file is committed as part of a new tag. Once this is done, the goal is to leave the current working branch in the same state it was in before the release. We accomplish this by checking out the previous package.json from whatever branch we are working in.

    This ticket covers also reverting the package-lock.json file, as though we had issued the command git checkout package-lock.json.

  • Atisaya Jain commented 2018-03-13T13:20:13.636-0400

    Thank you so much for you help, Tony. It cleared a lot of doubts, really.

    I have opened a PR #9 on Github, please review it. And please let me know if any other changes need to be made.

  • Atisaya Jain commented 2018-03-16T06:48:03.644-0400

    @Justin Obara @Tony Atkins I closed the previous PR while trying to rename commits. I am really sorry for this.

    Please review PR #10 Github and let me know if any changes need to be made.

  • Justin Obara commented 2024-07-25T11:52:46.691-0400

    Migrated to https://github.com/fluid-project/fluid-publish/issues/22