FLUID-616: Height of upload queue does not decrease as files are removed from the list

Metadata

Source
FLUID-616
Type
Bug
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
Eli Cochran
Reporter
Eli Cochran
Created
2008-05-22T15:08:58.000-0400
Updated
2008-12-02T15:18:53.000-0500
Versions
  1. 0.3
Fixed Versions
  1. 0.3
Component
  1. Uploader

Description

Add enough files to the file queue in the file uploader so that the queue gets scrollbars.
Remove files one by one.
At some point the file queue will no longer have scrollbars
Keep removing files
Observe: the file queue height does not decrease

Environments

FF2 Mac

Comments

  • Eli Cochran commented 2008-05-23T12:05:39.000-0400

    Many things all conspired to make the old implementation impossible.
    The tbody element was both the scrolling element and the element that needed to be measured in order to know whether you needed to set the element to scrolling.
    So you can't test the height of the element since you're also setting the height of the element to get it to scroll. (Is this making sense)
    So instead of checking the height of the element, you check the offsetHeight of the element.
    But IE doesn't support offsetHeight. (OK, it supports it but gets it wrong).
    So you have to have a different element handle the scroll from the tbody which handles the height.
    Except that height also isn't supported on tbody elements in IE so you have to test against the entire table element.
    But you don't want to include headers and footers.

    And so, I exploded the table into three separate parts so I could scroll the middle. All because IE is wack!

  • Justin Obara commented 2008-12-02T15:18:53.000-0500

    appears to have been fixed