FLUID-611: Bad JavaScript in MultiFileUpload.js

Metadata

Source
FLUID-611
Type
Bug
Priority
Critical
Status
Closed
Resolution
Fixed
Assignee
Eli Cochran
Reporter
Former user
Created
2008-05-16T20:35:41.000-0400
Updated
2008-07-11T16:06:44.000-0400
Versions
  1. 0.3
Fixed Versions
  1. 0.3
Component
  1. Uploader

Description

The createUploadCompleteHandler function contains the following line:

fileQueueComplete(uploaderContainer, options, progressBar, fragmentSelectors);

However, "options" is undefined in this context. Looks like a bad copy-and-paste, not caught because the no-server-side demo doesn't exercise that function.

I've worked around it by just adding "options" to the parameter list:

var createUploadCompleteHandler = function (uploaderContainer, progressBar, fragmentSelectors, status, options) {
...
upload_complete_handler: createUploadCompleteHandler (uploaderContainer, progressBar, fragmentSelectors, status, options),

Comments

  • Eli Cochran commented 2008-05-29T16:31:20.000-0400

    options added all around