FLUID-6104: fluid-publish module should use a "+" to separate the build metadata

Metadata

Source
FLUID-6104
Type
Bug
Priority
Critical
Status
Closed
Resolution
Won't Fix
Assignee
N/A
Reporter
Justin Obara
Created
2017-01-09T09:54:54.045-0500
Updated
2018-04-06T09:52:42.185-0400
Versions
N/A
Fixed Versions
N/A
Component
  1. Build Scripts
  2. Release

Description

Currently fluid-publish creates dev builds and appends the date and commit hash to the end. This is currently separated by a "." but should be separate by a "+" according to http://semver.org/#spec-item-10

Comments

  • Justin Obara commented 2017-01-18T14:11:58.281-0500

    Upon further review it seems that build metadata doesn't affect precedence of builds. I wonder if we'd prefer to keep things as is so that they are ordered. It's not clear if this will be the case with using buildmetada.

    http://semver.org/#spec-item-11

  • Justin Obara commented 2018-04-06T09:51:10.805-0400

    In doing some further investigation into build metadata while working on FLUID-6270 I found that npm strips out this information. It seems the logic is that because it can't be used to sort versions, as build metadata give equal precedence, it is to be ignored and thus stripped out.

    See:

  • Justin Obara commented 2018-04-06T09:52:42.183-0400

    We actually want to use the data and commit has for sorting, so this seems like it would be counter productive. Also, if the build metadata is stripped it will just end up creating a mess of our npm repo.