FLUID-5879: There should be a way to exclude elements from font changes, to assist with icon font usage

Metadata

Source
FLUID-5879
Type
Improvement
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
Eloisa Guerrero
Reporter
Justin Obara
Created
2016-03-21T10:09:45.480-0400
Updated
2017-08-17T15:53:44.249-0400
Versions
N/A
Fixed Versions
  1. 3.0
Component
  1. Prefs Framework

Description

Currently the prefs framework will change the font used for the entire page when the text style preference is set. However, this is problematic when icon fonts are used because those specific fonts should remain unchanged. We work around this in our components through specificity and setting them with !important. However, a more general approach could be to take an approach like FLUID-5697 did and have a means of explicitly excluding elements.

Comments

  • Justin Obara commented 2016-03-21T10:12:15.068-0400

    A possible solution would be to make use of the :not() pseudo class in our styles and explicitly exclude some class. Maybe "fl-icon" or something.

  • Justin Obara commented 2017-08-17T15:53:38.498-0400

    Merge PR ( https://github.com/fluid-project/infusion/pull/841 ) into the project repo at 2e5bd5bf9be43ecf0f5303cf3a206b866e35ba6f