Metadata
- Source
- FLUID-5743
- Type
- Bug
- Priority
- Major
- Status
- Closed
- Resolution
- Fixed
- Assignee
- Antranig Basman
- Reporter
- Antranig Basman
- Created
2015-08-17T15:08:14.163-0400 - Updated
2017-02-27T15:49:09.941-0500 - Versions
- N/A
- Fixed Versions
-
- 2.0
- Component
-
- IoC System
Description
In preparing the FLUID-5249 branch for being the Infusion 2.0.0-beta.1 release candidate, it was noticed that the order of grade merging priority had been inverted. The previous 1.9-x branch had grades mentioned to the right of the list in gradeNames overriding those to the left, whereas we now had grades at the left overriding those at the right. This change had also been reflected in the docs accompanying the release, assuming that the previous docs had been in error and that the implemented behaviour was unchanged. We need to back out both the error in the framework and in the docs, and restore the behaviour that a straw poll has determined is intuitively more desirable - that is, grades reading from left to right becoming successively more powerful - and also reflecting the framework's internal order in "mergeBlocks".
Comments
-
Antranig Basman commented
2015-08-18T13:58:47.602-0400 Correction to the earlier timeline - grade have IN FACT been in "Arabic order" since at least late 2013 (dating from the fix of FLUID-5085). It appeared that they were overriding in the opposite direction in https://github.com/colinbdclark/bergson/blob/infusion-2.x/tests/js/utils/scheduler-test-utilities.js#L225 because of the FLUID-5714 "funcName" overriding bug. The docs were indeed wrong on this issue during the last few years, and are only now being corrected for the FLUID-5249 fix and for this fix.
-
Antranig Basman commented
2015-08-20T19:43:55.980-0400 Merged into trunk at revision 6f88f9f4b925a5d3da9e7cd8862e5bd4c9a02b45