Metadata
- Source
- FLUID-5599
- Type
- Improvement
- Priority
- Major
- Status
- Closed
- Resolution
- Fixed
- Assignee
- Antranig Basman
- Reporter
- Justin Obara
- Created
2015-02-25T10:44:36.907-0500 - Updated
2016-03-22T11:03:34.745-0400 - Versions
- N/A
- Fixed Versions
-
- 1.9
- Component
-
- Prefs Framework
Description
The current system requires a user to pass in the location of the specific message bundles that are to be used by the prefsEditor, panels, and etc. However to support a language adjuster for the First Discovery Tool http://issues.fluidproject.org/browse/FLOE-281 we'll need a system that is more robust.
Instead a user should pass in a reference to the base name of message bundle, from there the system will go through an algorithm trying to locate the correct bundle and falling back to a default one if the desired langauge is not located.
e.g.
fr-ca is requested.
will look in this order for the message bundle fr-ca -> fr -> en (default)
Additionally the prefsEditor will need to take in a default language as an option, so that we'll know what to fall back to. However, the current language setting will first look into a model value (so that this can be part of a store preference) to set the components language.
Comments
-
Justin Obara commented
2015-02-25T13:02:53.335-0500 The reference to the JAVA naming scheme for resource bundle fallback based on language
http://docs.oracle.com/javase/7/docs/api/java/util/ResourceBundle.html#getBundle(java.lang.String, java.util.Locale, java.lang.ClassLoader)Implementing this as far as baseName_language_country would be good enough for now
See today's channel conversation with Bosmon7
https://botbot.me/freenode/fluid-work/2015-02-25/?tz=America/Toronto -
Cindy Li commented
2015-05-04T15:17:16.499-0400 Merged Antranig's pull request (https://github.com/fluid-project/infusion/pull/596) for implementing the localised resource fetcher into the master branch @ 735a2f084bc72cc71338a5856cfae49268374e56
Issued another pull reqeust (735a2f084bc72cc71338a5856cfae49268374e58) to upgrade the prefs framework to fetch localized message bundles.
-
Antranig Basman commented
2015-05-07T10:44:46.580-0400 Merged into trunk at revision 76c6189 , incorporating fixes to FluidRequests.js as well as the prefs framework
-
Justin Obara commented
2015-06-26T09:51:35.811-0400 Reopening to change the fix version to 1.9