Metadata
- Source
- FLUID-5554
- Type
- Bug
- Priority
- Blocker
- Status
- Closed
- Resolution
- Fixed
- Assignee
- Justin Obara
- Reporter
- Anastasia Cheetham
- Created
2014-11-12T10:15:47.815-0500 - Updated
2015-06-26T10:16:37.535-0400 - Versions
-
- 1.5
- Fixed Versions
-
- 1.5.1
- 1.9
- Component
-
- Prefs Framework
Description
As part of its initialization, the text size enactor calculates the initial pixel size and hard-codes that onto the root element to ensure that rems in the CSS will work. Incorrectly, the initial calculation is not using the root but rather the container. This causes problems if the root and container don't have the same initial font size. The calculation should be based on root.
This problem was discovered when adding UIO to a Wordpress child theme. Without UIO, the html element (the root) and the body element (the container) had different font sizes initially (10px and 18px respectively). When 18px was added to the html element, everything on the page expanded to enormous size.
Comments
-
Anastasia Cheetham commented
2014-11-12T10:23:02.408-0500 Justin suggests that this fix should go into the 1.5.x branch as well as master.
-
Anastasia Cheetham commented
2014-11-12T10:45:00.607-0500 Two pull requests:
master: https://github.com/fluid-project/infusion/pull/568
1.5.x: https://github.com/fluid-project/infusion/pull/569 -
Justin Obara commented
2014-11-12T12:49:32.296-0500 Merged pull request ( https://github.com/fluid-project/infusion/pull/568 ) into the master branch of the project repo at de2ea6df7df284829621f99c1a89ba50ebfcea2d
-
Justin Obara commented
2014-11-12T14:35:38.253-0500 Merged pull request ( https://github.com/fluid-project/infusion/pull/569 ) into the infusion-1.5.x branch of the project repo at 266bec518687521c2611951bc29fb6baa87d4ef6
-
Justin Obara commented
2015-06-26T09:51:30.907-0400 Reopening to change the fix version to 1.9