Metadata
- Source
- FLUID-5264
- Type
- Bug
- Priority
- Major
- Status
- Closed
- Resolution
- Fixed
- Assignee
- Antranig Basman
- Reporter
- Justin Obara
- Created
2014-01-31T13:16:59.105-0500 - Updated
2017-02-27T15:49:10.858-0500 - Versions
- N/A
- Fixed Versions
-
- 2.0
- Component
-
- Progressive Enhancement
Description
Currently the progressiveCheckerForComponent looks up a components defaults when attempting to find the the progressiveCheckerOptions.
However, this ignores any options supplied to component at instantiation time. Amongst other things, this prevents an integrator from directly adding a progressive enhancement step to a component at instantiation.
Comments
-
Justin Obara commented
2014-01-31T13:19:52.049-0500 Submitted a pull request with a unit test for the issue
https://github.com/fluid-project/infusion/pull/460 -
Antranig Basman commented
2014-03-18T21:50:49.236-0400 I tried making a simpleminded fix for this issue based on "fluid.getForComponent" but discovered that our usage pattern in the Uploader is too complex to be cleared up without major work. The issue is that the uploader is created in two varieties of configuration, one where the progressiveChecker is attached to the component as "uploaderContext" and another where it is attached to the "staticEnvironment". All of these areas of the framework are in the process of being rethought, together with JIRAs such as http://issues.fluidproject.org/browse/FLUID-5249 and http://issues.fluidproject.org/browse/FLUID-5241 - so it would be best to rework this implementation thoroughly - at the same time renaming it as "contextAwareness" or so.
-
Justin Obara commented
2015-06-15T14:28:57.422-0400 pull request: https://github.com/fluid-project/infusion/pull/591
-
Antranig Basman commented
2015-08-20T10:01:35.270-0400 Merged into trunk at revision 282f1a318718eed0b0ec060fb8b4ad254417fd7e
progressiveChecker is abolished and replaced by contextAwareness