FLUID-5218: Prefs editor requires iFrame template to be in same place as panel templates; it probably shouldn't

Metadata

Source
FLUID-5218
Type
Bug
Priority
Critical
Status
Closed
Resolution
Fixed
Assignee
N/A
Reporter
Anastasia Cheetham
Created
2013-11-21T11:51:54.049-0500
Updated
2024-07-22T14:52:49.507-0400
Versions
  1. 1.5
  2. 2.0
  3. 3.0
Fixed Versions
  1. 5.0
Component
  1. Prefs Framework

Description

Currently, the prefs framework builder allows the aux schema to specify a 'template prefix' which is used as the path to all the templates, including both panel templates and the SeparatedPanelPrefsEditorFrame.html template.

From an integrator's perspective, the SeparatedPanelPrefsEditorFrame.html is conceptually in a different class than the panel templates. The panel templates are mine to design, custom to my implementation, but it's likely rare that I'd ever want to customize the SeparatedPanelPrefsEditorFrame.html I think the iFrame template should be treated as a special case.

I recommend that the framework somehow default to use the SeparatedPanelPrefsEditorFrame.html that is present in the framework's own html folder. This would require the integrator to specify an additional prefix, the relative path to the framework html folder. This could perhaps be called "panelTemplatePrefix" or something similar.

If the integrator perhaps does want to create their own custom SeparatedPanelPrefsEditorFrame.html, then they could simply set "panelTemplatePrefix" to wherever the template it - perhaps event the same value as "templatePrefix" if that's where they put it.

Comments

  • Anastasia Cheetham commented 2013-11-21T15:57:53.606-0500

    Of course, if the integrator is designing their own templates, they're probably going to have their own styles, in which case they'll have to copy the SeparatedPanelPrefsEditorFrame.html in order to add the link to the css file.

  • Justin Obara commented 2024-07-22T14:52:41.127-0400

    The iframe was removed with FLUID-6749