FLUID-5209: ensure that listeners in the preference framework are properly namespaced

Metadata

Source
FLUID-5209
Type
Bug
Priority
Blocker
Status
Closed
Resolution
Fixed
Assignee
Justin Obara
Reporter
Justin Obara
Created
2013-11-11T09:44:40.353-0500
Updated
2016-08-30T13:03:34.722-0400
Versions
  1. 1.5
Fixed Versions
  1. 2.0
Component
  1. Prefs Framework

Description

Currently there are listeners like the onReset defined in the fullNoPreview preference editor that aren't properly namespaces.
https://github.com/fluid-project/infusion/blob/master/src/framework/preferences/js/FullNoPreviewPrefsEditor.js#L33-L37

This means that if you want to use the fullNoPreview prefs editor but want a reset that doesn't save, you won't be able to use this base grade. There is no way to override this event, as providing new configuration will just merge.

The entire preference framework should be examined to resolve similar issues.

Comments

  • Justin Obara commented 2016-08-30T12:56:36.104-0400

    Did not namespace listeners that are bound to events of other components using IoC. These have not be namespace due to FLUID-5948

  • Cindy Li commented 2016-08-30T13:03:27.630-0400

    The pull request https://github.com/fluid-project/infusion/pull/742 has been merged into the project master branch at b11549a25f77fc83d5d989f77fbec1f396d474e2