FLUID-5192: Slider icon text not being rendered

Metadata

Source
FLUID-5192
Type
Bug
Priority
Critical
Status
Closed
Resolution
Fixed
Assignee
Justin Obara
Reporter
Anastasia Cheetham
Created
2013-10-28T11:22:35.530-0400
Updated
2016-08-12T10:22:37.648-0400
Versions
N/A
Fixed Versions
  1. 2.0
Component
  1. Prefs Framework

Description

In the two starter panels that use the textfieldSlider (textSize and lineSpacing), there are message strings in the string files that are intended to be rendered into the divs for the icons at either end of the slider. The selectors for these strings are specified in the panel component defaults and the prototrees include them. However, the current HTML templates are missing the selector classnames, and so the strings are not being rendered.

Comments

  • Michelle D'Souza commented 2014-03-27T15:05:28.760-0400

    @@joanna vass@@Dana@@Justin Obara There was some conversation about whether or not this is an issue that we should actually fix. Justin, could you clarify what the questions are and perhaps we can move towards fixing or closing this issue.

  • Justin Obara commented 2015-06-15T10:49:28.579-0400

    I believe the questions are around whether or not those icons should actually have any aria-labels at all. They appear to be purely presentational.

  • Justin Obara commented 2016-08-12T08:00:18.303-0400

    The slider icons were marked with role=presentation as a fix for FLUID-5680. The associated strings should be removed from the message bundles and any other scaffolding left to insert them in the components should be removed.

  • Cindy Li commented 2016-08-12T10:22:33.897-0400

    The pull request has been merged into the master branch at 8c675a5a4a90a1e8d50074ae08541e067bcb64fe