Metadata
- Source
- FLUID-5123
- Type
- Task
- Priority
- Major
- Status
- Closed
- Resolution
- Fixed
- Assignee
- N/A
- Reporter
- Justin Obara
- Created
2013-09-03T15:53:04.943-0400 - Updated
2013-10-08T13:39:34.684-0400 - Versions
- N/A
- Fixed Versions
-
- 1.5
- Component
-
- Prefs Framework
- UI Options
Description
Remove onIfameVisible event and listener as it no longer seems necessary to reapply the text size and line-space values in the iframe.
// Re-apply text size and line space to iframe content since these initial css values are not detectable
// when the iframe is hidden.
iframeEnhancer.events.onIframeVisible.addListener(function () {
iframeEnhancer.applier.requestChange("", iframeEnhancer.model);
});
Should also update the unit tests if needed.
Can remove the following blocks:
https://github.com/fluid-project/infusion/blob/master/src/components/uiOptions/js/FatPanelUIOptions.js#L112-L114
https://github.com/fluid-project/infusion/blob/master/src/components/uiOptions/js/FatPanelUIOptions.js#L224
https://github.com/fluid-project/infusion/blob/master/src/components/uiOptions/js/FatPanelUIOptions.js#L244-L248
Comments
-
Justin Obara commented
2013-10-08T08:47:44.351-0400 Seems that this is needed after all. (see: FLUID-5171)
-
Justin Obara commented
2013-10-08T11:29:05.667-0400 Seems that it isn't actually related, as FLUID-5171 was fixed by making the invokers dynamic.
-
Justin Obara commented
2013-10-08T13:01:44.489-0400 Addressed with work for FLUID-5161
-
Justin Obara commented
2013-10-08T13:39:34.682-0400 Merged pull request ( https://github.com/fluid-project/infusion/pull/414 ) into the project repo at b4422d732612a84ba429f3866b97786e627d8fb1