FLUID-5119: move lookupMsg function from SlidingPanel.js to framework

Metadata

Source
FLUID-5119
Type
Task
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
N/A
Reporter
Justin Obara
Created
2013-08-20T09:04:57.058-0400
Updated
2014-03-26T16:19:32.516-0400
Versions
N/A
Fixed Versions
N/A
Component
  1. Framework
  2. Sliding Panel

Description

The code to look up messages in a message bundle for non-renderer components is currently in SlidingPanel.js. However, this seems like a useful function that should be moved to the framework as a general utility for any component to use. It looks like the discovery tool will already need to make use of this.

Current code:

fluid.slidingPanel.lookupMsg = function (messageResolver, value) {
var looked = messageResolver.lookup([value]);
return looked ? looked.template : looked;
};

https://github.com/fluid-project/infusion/blob/master/src/components/uiOptions/js/SlidingPanel.js#L72-L75

Comments

  • Justin Obara commented 2013-10-15T15:12:32.018-0400

    May want to consider moving the code changes from FLUID-5180 to the framework instead of the one from slidingPanel.js

  • Justin Obara commented 2013-10-18T13:15:14.822-0400

    Submitted pull request https://github.com/fluid-project/infusion/pull/419

    The pull request doesn't move the lookupMsg to the framework, but rather removes it completely. FLUID-5180 defined a new lookup method, which is employed in the SeparatedPanelPrefsEditor's instance of slidingPanel.

  • Justin Obara commented 2014-03-26T16:19:32.516-0400

    pull request merged at 861d635d56c7546c764d23cf40e7f96e85516b17