FLUID-4794: the framework's progressive enhancement support should include an API for clients to be able to register their own feature checking functions

Metadata

Source
FLUID-4794
Type
Bug
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
Justin Obara
Reporter
Alexey Novak
Created
2012-09-12T11:30:05.520-0400
Updated
2013-02-14T08:33:36.556-0500
Versions
N/A
Fixed Versions
  1. 1.5
Component
  1. UIEnhancer

Description

https://github.com/fluid-project/infusion/blob/master/src/webapp/framework/enhancement/js/ProgressiveEnhancement.js

Current ProgressiveEnhancement implementation does not allow developers to add their own features or extend an existing feature check (fluid.browser)

Currently videoPlayer has a copy paste code taken from the ProgressiveEnhancement implementation in order to add check for HTML5 and browser full screen support.
https://github.com/fluid-project/videoPlayer/blob/master/js/VideoPlayer.js#L28-50

In this particular example a new set of features is being defined and then merged into staticEnvironment. The proper way is to reuse ProgressiveEnhancement.

Comments

  • Antranig Basman commented 2013-02-14T03:08:46.178-0500

    Thanks for the branch work with this, Justin - now in trunk

  • Justin Obara commented 2013-02-14T08:33:36.449-0500

    Merged into the project repo at 585ae84e652099a9f944d0bd8dd3fe342bff411e