FLUID-4733: Implementation of "default value merge policies" is inadequate

Metadata

Source
FLUID-4733
Type
Bug
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
Justin Obara
Reporter
Antranig Basman
Created
2012-07-20T17:22:00.096-0400
Updated
2014-03-03T12:50:39.064-0500
Versions
N/A
Fixed Versions
  1. 1.5
Component
  1. Framework

Description

Right now it is possible to specify "EL right hand" merge policies as currently seen in the Reorderer like so:

mergePolicy: {
keysets: "replace",
"selectors.labelSource": "selectors.grabHandle",
"selectors.selectables": "selectors.movables",
"selectors.dropTargets": "selectors.movables"
},

the implementation in Fluid.js has a number of problems, for a start, that it has not been updated to consider that the new "policy-based" merge policies are not EL names (Fluid.js line 1231)
if (typeof (elrh) === "string" && elrh !== "replace" && elrh !== "preserve") {
however, the need to maintain these names in step with the actual implementation only show the fragility of this mechanism which could never be perfectly sure that a policy name actually represents a policy rather than an EL path. We expect this facility to be completely reimplemented as part of the FLUID-4392 work, but in the meantime we should at least deal with this glaring bug.

Comments

  • Antranig Basman commented 2013-02-19T14:54:27.293-0500

    Resolved by merge of FLUID-4330 branch at revision 91d5d1