FLUID-4602: When using the HTML5 strategy, the browseButton selector cannot be changed

Metadata

Source
FLUID-4602
Type
Bug
Priority
Critical
Status
Closed
Resolution
Fixed
Assignee
Colin Clark
Reporter
Justin Obara
Created
2012-02-14T08:31:17.420-0500
Updated
2012-02-14T12:34:01.422-0500
Versions
  1. 1.4
Fixed Versions
  1. 1.5
Component
  1. Uploader

Description

Attempting to change the browseButton selector when using the HTML5 strategy will have no effect. This is caused by an error in the default configuration of fluid.uploader.html5Strategy.local.

https://github.com/fluid-project/infusion/blob/master/src/webapp/components/uploader/js/HTML5UploaderSupport.js#L327-347

The browseButton selector is set to "{multiFileUploader}.selectors.browseButton" instead of "{multiFileUploader}.options.selectors.browseButton"

Comments

  • Justin Obara commented 2012-02-14T10:13:15.812-0500

    I've made the necessary changes and verified that the unit tests are still passing. I've sent a pull request for the changes.
    https://github.com/fluid-project/infusion/pull/202

  • Colin Clark commented 2012-02-14T12:33:35.752-0500

    I've reviewed, tested, and pushed Justin's fix to master.

  • Colin Clark commented 2012-02-14T12:34:01.413-0500

    Resolved and fixed in Infusion master at fc0f49ffd55700159f6c66a5a1135b126cc04329