FLUID-4588: Uploader only accepts 200 as a successful response for a file upload

Metadata

Source
FLUID-4588
Type
Bug
Priority
Critical
Status
Closed
Resolution
Fixed
Assignee
Justin Obara
Reporter
Justin Obara
Created
2012-02-02T14:07:25.999-0500
Updated
2012-02-02T15:23:43.119-0500
Versions
  1. 1.4
Fixed Versions
  1. 1.5
Component
  1. Uploader

Description

Currently Upoader will only accept a 200 status as success
https://github.com/fluid-project/infusion/blob/master/src/webapp/components/uploader/js/HTML5UploaderSupport.js#L95-108

It should however probably accept anything from 200 to 204
http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html

Comments

  • Justin Obara commented 2012-02-02T14:49:24.967-0500

    Instead of just taking a 200 status as a success, anything in the range of 200 to 204 inclusive is now accepted. I didn't take the full range of 2xx responses as they did not all seem applicable to file uploads through the uploader. The unit tests have also be updated.

    Pull request:
    https://github.com/fluid-project/infusion/pull/200

  • Colin Clark commented 2012-02-02T15:22:55.635-0500

    I've reviewed Justin's code, tested it out, and pushed to the project repo.

  • Colin Clark commented 2012-02-02T15:23:43.117-0500

    Reviewed, pushed, closed.