FLUID-4569: Setting SlidingPanel 'hideByDefault' to false doesn't work properly

Metadata

Source
FLUID-4569
Type
Bug
Priority
Critical
Status
Closed
Resolution
Fixed
Assignee
N/A
Reporter
Anastasia Cheetham
Created
2011-12-13T12:27:05.280-0500
Updated
2014-03-26T16:18:40.626-0400
Versions
  1. 1.4
Fixed Versions
N/A
Component
  1. Prefs Framework
  2. Sliding Panel
  3. UI Options

Description

The fat panel UIO is hidden by default. The Sliding Panel's 'hideByDefault' option is supposed to allow integrators to change this: Setting 'hideByDefault' to false should result in the panel being visibile initially.

In fact, setting 'hideByDefault' to false doesn't work:

  • the panel is not visible initially
  • the toggleButton is not initialized with the correct text (neither the 'show' text nor the 'hide' text)

The first activation of the toggleButton does set the button text to the "show" text, which is correct, and future use of the panel is as expected.

Looking at the SlidingPanel initialization code, you can see that there is a code block to correctly initialize the panel in its hidden state, but there is no corresponding block to correctly initialize the panel in its visible state.

Comments

  • Justin Obara commented 2013-10-18T13:18:17.434-0400

    Submitted pull request https://github.com/fluid-project/infusion/pull/419

    Actually this issues is somewhat out of date as the slidingPanel has been model bound for a while. However, steps have been taken to ensure that the initial state is based on the model value.

  • Justin Obara commented 2014-03-26T16:18:38.229-0400

    pull request merged at 861d635d56c7546c764d23cf40e7f96e85516b17