FLUID-4519: Default line height in UIO demo overlaps the lines

Metadata

Source
FLUID-4519
Type
Bug
Priority
Critical
Status
Closed
Resolution
Cannot Reproduce
Assignee
N/A
Reporter
James Yoon
Created
2011-10-11T17:00:22.669-0400
Updated
2013-10-04T09:33:22.905-0400
Versions
  1. 1.4
Fixed Versions
N/A
Component
  1. UI Options

Description

The default line height of the text in the UIO demo is too tight, and causes the lines to overlap with each other.

This happens even when no settings are applied, but is most visible when one carries out the following:
1. Increase text size to maximum
2. Change contrast theme to b/w
3. Note behaviour of text and line height under section 1 of "Some helpful tips"

Environments

Win 7 Firefox

Attachments

Comments

  • Cindy Li commented 2011-10-12T10:11:46.206-0400

    UIEnhancer currently sets calculated em value of "line-height" on the <body> tag to achieve the line spacing adjustment. However, rather than this em value being inherited by the descendant elements of <body>, it was the computed px value that's calculated based on the <body> font size. Since the descendant elements that have larger font size are supposed to have larger line height, the px value that's computed based on the <body> font size would be too small for them which results in the overlapping.

    The potential solution is, rather than applying em value onto <body> line-height, apply the multiplier number value instead.

    The reference doc of the valid "line-height" values: http://www.w3schools.com/cssref/pr_dim_line-height.asp

    A useful presentation of how "line-height" is inherited and calculated: http://www.slideshare.net/maxdesign/line-height

  • Justin Obara commented 2013-10-04T09:33:22.902-0400

    Seems to have been fixed.