FLUID-4370: The ".. on Black" contrasts have dark grey text and icons

Metadata

Source
FLUID-4370
Type
Bug
Priority
Blocker
Status
Closed
Resolution
Fixed
Assignee
N/A
Reporter
Justin Obara
Created
2011-07-28T13:17:30.935-0400
Updated
2013-04-11T16:35:31.413-0400
Versions
N/A
Fixed Versions
  1. 1.4
Component
  1. UI Options

Description

The "Yellow on Black" and "White on Black" contrast themes set some of the text and the icons to be dark grey. This provides a very low contrast and makes it hard to view.

Steps to reproduce

1) Open any of the UIO demos
http://build.fluidproject.org/infusion/demos/uiOptions/FullNoPreviewUIOptions/html/uiOptions.html
http://build.fluidproject.org/infusion/demos/uiOptions/FullPreviewUIOptions/html/uiOptions.html
http://build.fluidproject.org/infusion/demos/uiOptions/FatPanelUIOptions/html/uiOptions.html

2) Change the contrast to either "Yellow on Black" or "White on Black"
Notice the dark grey text and icons

Attachments

Comments

  • Justin Obara commented 2011-07-28T13:18:55.745-0400

    ScreenShot.png shows the dark grey text and icons against the black background

  • Justin Obara commented 2011-07-28T13:19:08.342-0400

    Bug Parade Infusion

  • Justin Obara commented 2011-08-29T15:04:09.209-0400

    "ScrreenShot - IE6.png" shows an issue with the current state of the FLUID-4370 branch in IE6 ( https://github.com/jobara/infusion/commit/d63ab6c0a980eb7e8a10f2ccc8e7f83d2fa6eea7 ) It appears that the last theme being added is overriding other styles that aren't explicitly being set in a theme. This shows up clearly on the black on white theme where large portions of the UI still have black backgrounds instead of white. Also the select drop down is styled all in yellow on black. If I remove the fl-preview-theme class from UI Enhancer, things start to work a bit better.

  • Justin Obara commented 2011-08-29T15:39:17.407-0400

    "ScreenShot - S5.png" shows how the black on white contrast theme currently looks in Safari 5. Which is pretty much how it should be styled.

  • Justin Obara commented 2011-08-30T11:17:42.135-0400

    Sent a pull request https://github.com/fluid-project/infusion/pull/143 . The IE6 issue mentioned above was taken care of by changing the order of the class names used in the theme file.

  • Justin Obara commented 2011-08-30T11:18:19.989-0400

    I didn't have the contrast theme specific versions of the arrows used in the UIO demo, this should be added in another jira.

  • Michelle D'Souza commented 2011-09-02T09:23:06.345-0400

    Pull request https://github.com/fluid-project/infusion/pull/146 merged into project repo at e8af4dd1d5003291d5be73eb09014cc38cb794fb