FLUID-4340: jqUnit.assertDeepEq has exponential computational time when comparing two trees with a lot of levels

Metadata

Source
FLUID-4340
Type
Improvement
Priority
Minor
Status
Closed
Resolution
Fixed
Assignee
Justin Obara
Reporter
Harris Wong
Created
2011-07-14T10:17:45.383-0400
Updated
2014-03-03T13:05:21.922-0500
Versions
N/A
Fixed Versions
  1. 1.4
Component
  1. Framework

Description

Description:
When using jqUnit.assertDeepEq to compare two trees, the run time grows exponentially and causes the browser to throw a timeout error.

Suggested Fix:
Use deepEqual(actual, expected, message) instead. Wrap this function with our assertDeepEq.

Additional Notes:
This might be the same for assertDeepNeq as well.

Environments

FF5, Chrome on Ubuntu.

Comments

  • Antranig Basman commented 2011-07-28T17:45:22.566-0400

    Fixed with fix of FLUID-4360