Metadata
- Source
- FLUID-4320
- Type
- Task
- Priority
- Major
- Status
- Closed
- Resolution
- Fixed
- Assignee
- Michelle D'Souza
- Reporter
- Michelle D'Souza
- Created
2011-07-04T12:52:49.020-0400 - Updated
2015-06-09T14:04:56.807-0400 - Versions
-
- 1.4
- Fixed Versions
-
- 1.5
- Component
-
- Prefs Framework
- UIEnhancer
Description
Text Sizer and Line Spacer use a similar strategy for enacting the setting upon the page and can be refactored to allow better code reuse. Here is the code review comment from Antranig for FLUID-4207:
Hi, these changes generally look very good. It's good to see the functions broken out into the public namespace and the new "half-ants". The only problematic area I see is the "set" functions. The responsibilities of these aren't well factored, and a lot of the implementation is in common. The "middle section" should instead be reformed as a "model normalisation function" which takes an incoming value ("times") into one which is suitable to set directly via xxxx.css(). The "ant" should then take as configuration the name of the CSS property which it modifies, and then the rest of the workflow of "set" can be in common between the "half-ants". It might be worth descending them from some common grade, or sharing implementation in some other way.
Comments
-
Justin Obara commented
2013-09-06T12:57:40.665-0400 The refactoring should probably revolve around grades now. Both of these panels could share a common grade and have specific configuration for the differences.
-
Justin Obara commented
2015-06-09T14:04:56.805-0400 The underlying codebase for which this jira referenced, has already been refactored, likely in work for Infusion 1.5.