FLUID-4318: Tabs component needs its own css file

Metadata

Source
FLUID-4318
Type
Task
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
heidi valles
Reporter
heidi valles
Created
2011-06-30T16:19:37.617-0400
Updated
2011-07-08T16:16:21.436-0400
Versions
N/A
Fixed Versions
  1. 1.4
Component
  1. Tabs

Description

Right now ../../../lib/jquery/ui/css/demo-theme/jquery.ui.theme.css is required for the Tabs to look like tabs, but instead the tabs portion of this file should be in a tabs.css file in the component dir

Comments

  • heidi valles commented 2011-06-30T16:19:47.089-0400

    Bug Parade Infusion

  • heidi valles commented 2011-07-06T10:14:53.471-0400

    Because it is actually a jquery widget, and our component is only a wrapper, expecting the user to include a jquery ui theme file isn't a stretch. We'll just rename demo-theme/ to default-theme/ (it's not currently used by anything right now), and have this be a sort of place-holder for our default infusion theme that will someday exist.

  • heidi valles commented 2011-07-06T10:17:34.711-0400

    IRC discussion: http://wiki.fluidproject.org/display/fluid/fluid-work+IRC+Logs-2011-07-06 8.22am-9.16am

  • heidi valles commented 2011-07-07T14:43:39.077-0400

    Renamed demo-theme to default-theme: /lib/jquery/ui/css/default-theme/jquery.ui.theme.css req'd for Tabs component

  • heidi valles commented 2011-07-07T15:05:37.280-0400

    See http://issues.fluidproject.org/browse/FLUID-4329 re: tabs styling in fat panel

  • Anastasia Cheetham commented 2011-07-07T15:09:44.846-0400

    Heidi's fix was merged at commit 7bd27e50645115ffe00f94870deefe7ac223edfd.