Metadata
- Source
- FLUID-4266
- Type
- Task
- Priority
- Major
- Status
- Closed
- Resolution
- Fixed
- Assignee
- N/A
- Reporter
- Michelle D'Souza
- Created
2011-05-26T11:26:47.555-0400 - Updated
2013-09-06T12:59:48.674-0400 - Versions
-
- 1.4
- Fixed Versions
-
- 1.5
- Component
-
- UI Options
Description
Currently UIOptions both contains all the dialog functionality as well as has several subcomponents. This can be factored better as Antranig points out in the following code review comment:
I would actually refactor this area quite significantly - uiOptions.preview should not be a subcomponent of uiOptions but actually a container/sibling of it. OR the thing currently called uiOptions should actually be renamed uiOptionsDialog - and this is the thing which has the link JUST to settingsStore and nothing else. Then the name "uiOptions" can be used for the "orchestrating component" which contains a preview, a uiOptionsDialog, a settingsStore and a uiEnhancer as direct children. Almost all the members which are currently on uiOptions (basically all the "controls") would go onto uiOptionsDialog.
Comments
-
Justin Obara commented
2013-09-06T12:59:48.671-0400 UIOptions has undergone major changes to have it structured around a notion of a preferences framework.