Metadata
- Source
- FLUID-4265
- Type
- Sub-task
- Priority
- Major
- Status
- Closed
- Resolution
- Fixed
- Assignee
- Michelle D'Souza
- Reporter
- Michelle D'Souza
- Created
2011-05-26T11:00:08.063-0400 - Updated
2011-06-07T16:26:33.195-0400 - Versions
- N/A
- Fixed Versions
-
- 1.4
- Component
-
- UIEnhancer
- UI Options
Description
Currently the defaultSiteSettings are part of UIEnhancer defaults instead of being a separate entity that is injected into both UIEnhancer and UIOptions when they require it.
Here are the code review comments from Antranig:
One resolution would be to reorganise the lines 242-245 to be delivered by a demands block, that only acted when a {uiEnhancer} was in scope. It is still problematic that so many defaults are defined within UIEnhancer itself - for example, the settingsStore and the defaultSiteSettings etc. I would move these out into a 3rd, largely dependence-free component called something like UIOptionsStore - they would be injected into both UIEnhancer and UIOptions from some shared location. This should just be specified as "fluid.uiOptions.store" and only resolved as "cookieStore" via a demands block. Right now, someone advising this implementation would have to issue a demands block against "fluid.uiEnhancer.cookieStore"
Comments
-
Michelle D'Souza commented
2011-05-26T13:29:51.587-0400 Bug Parade Infusion
-
Michelle D'Souza commented
2011-06-03T12:31:27.875-0400 Merged into FLUID-4267 branch at 4faf4acfa010d11919ee9df0cd93113f7548b09e