FLUID-4213: The pager's defaults contain configuration which requires it to be overridden or else will almost always fail.

Metadata

Source
FLUID-4213
Type
Bug
Priority
Blocker
Status
Closed
Resolution
Fixed
Assignee
Antranig Basman
Reporter
Justin Obara
Created
2011-05-10T14:15:31.831-0400
Updated
2011-05-11T16:23:14.489-0400
Versions
  1. 1.3.1
Fixed Versions
  1. 1.4
Component
  1. Pager

Description

When converting the pager to use self-rendered version by default ( for FLUID-2329 ), some problematic configuration was added at the same time.

https://github.com/fluid-project/infusion/blob/5c50980c58cb59498c187d8871c2e50c5ebf7a79/src/webapp/components/pager/js/Pager.js#L857-865

The "annotateColumnRange" option should have been left as undefined, and there shouldn't have been any default "columnDefs". In place of the "columnDefs" a comment explaining how to fill it out would have been better. Something like what was done in the progressiveEnhancer.

https://github.com/fluid-project/infusion/blob/master/src/webapp/framework/enhancement/js/ProgressiveEnhancement.js#L52

This issue was reported in the fluid-work irc channel:
http://wiki.fluidproject.org/display/fluid/fluid-work+IRC+Logs-2011-05-09

Comments

  • Justin Obara commented 2011-05-10T15:44:00.608-0400

    Sent a pull request to merge changes from my FLUID-4213 branch in github. https://github.com/fluid-project/infusion/pull/41
    I've modified the defaults annotateColumnRange is set to undefined again, and the columnDefs are set to an empty array, with a comment showing the correct format.
    A unit test has been provided

  • Justin Obara commented 2011-05-11T16:23:14.487-0400

    Antranig merged this into the project repo at 844e1be791b768d12a686edca7fb3d54637cd0e8